Skip to content

lint: Add lint rule for calls to renderHook and derivitives#106492

Open
ryan953 wants to merge 9 commits intomasterfrom
ryan953/lint-renderHook
Open

lint: Add lint rule for calls to renderHook and derivitives#106492
ryan953 wants to merge 9 commits intomasterfrom
ryan953/lint-renderHook

Conversation

@ryan953
Copy link
Copy Markdown
Member

@ryan953 ryan953 commented Jan 17, 2026 •
edited
Loading

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 17, 2026
@ryan953 ryan953 changed the title Ryan953/lint render hook lint: Add lint rule for calls to renderHook and derivitives Jan 17, 2026
scttcper
scttcper approved these changes Jan 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to point people towards the right thing

@ryan953
Copy link
Copy Markdown
Member Author

ryan953 commented Jan 17, 2026

nice to point people towards the right thing

@scttcper
Still having issues with N arguments :(
I think we might need a rule before this one that encourages component style {}: Props or something like that.

I paused iterating on it now, if you wanna pick at it.

@ryan953 ryan953 force-pushed the ryan953/lint-renderHook branch from b9b8a8b to 8a471c2 Compare January 17, 2026 23:14
@ryan953 ryan953 mentioned this pull request Jan 18, 2026
Closed
@ryan953 ryan953 force-pushed the ryan953/lint-renderHook branch from ab9304e to 6a34b8b Compare February 6, 2026 18:51
@ryan953 ryan953 marked this pull request as ready for review February 6, 2026 19:08
@ryan953 ryan953 requested review from a team as code owners February 6, 2026 19:08
cursor[bot]
cursor bot reviewed Feb 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread static/app/utils/useIsMountedRef.spec.tsx Outdated
@armenzg armenzg removed request for a team February 26, 2026 13:41
@getsantry
Copy link
Copy Markdown
Contributor

getsantry bot commented Mar 20, 2026

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Mar 20, 2026
@billyvg billyvg removed request for a team March 24, 2026 22:02
@getsantry getsantry bot removed the Stale label Mar 25, 2026
@getsantry
Copy link
Copy Markdown
Contributor

getsantry bot commented Apr 15, 2026

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@scttcper scttcper scttcper approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryan953 @scttcper